Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes XML encoding issues #740

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Fixes XML encoding issues #740

merged 6 commits into from
Dec 7, 2022

Conversation

epau
Copy link
Contributor

@epau epau commented Dec 5, 2022

Corresponding smithy-swift PR: smithy-lang/smithy-swift#488

Issue #

#711

Description of changes

This PR sets an explicit handling for nonConformingFloat...Strategy and updates tests to account for explicit XML root keys.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@epau epau requested a review from jbelkins December 5, 2022 19:16
@epau epau merged commit b605643 into main Dec 7, 2022
@epau epau deleted the epau/fix/xml-root-key branch December 7, 2022 18:25
@dayaffe dayaffe mentioned this pull request Oct 26, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants