fix: prefer EndpointResolver Bucket for S3 in http label, AccountId for S3Control host label #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
S3 Bucket deduplication
Bucket
in the HTTP URI is now acontextParam
hence rules engine takes care of adding the bucket to the URI to either host name or path depending on the bucket locationforceStylePath
configuration. Therefore, SDK must not add the bucket to the URI outside of the rules engine.S3 Control AccountId deduplication
AccountId
hostPrefix is now astaticContextParams
hence rules engine takes care of addingAccountId
to the host name. This is enabled by settingRequiresAccountId
param in staticContextParams totrue
. Therefore, SDK must not add theAccountId
to the host name outside of the rules engine.New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.