-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configured endpoint resolution (aka service-specific endpoint configuration) #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConfigDefaultsProvider.configuredEndpoint that resolves configured endpoint if needed.
…; it uses AWSEndpointConfig to resolve and return configured endpoint if needed & possible.
…& possible. Add unit tests for it too.
…new test case for multiple services in services section case. Confirmed tests pass by depending on WIP branch of aws-crt-swift.
sichanyoo
changed the title
feat: Endpoint config resolution (aka service-specific endpoint configuration)
feat: Configured endpoint resolution (aka service-specific endpoint configuration)
Jan 9, 2025
dayaffe
approved these changes
Jan 9, 2025
2 tasks
…ervices section referenced by resolved profile doesn't exist, and add check for empty values for reoslved endpoint (empty values = proceed to next possible source). Implementation is 100% matching to SEP now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: smithy-lang/smithy-swift#895
Issue #
152
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.