-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading redux-offline and netinfo dependencies for react native #551
Upgrading redux-offline and netinfo dependencies for react native #551
Conversation
is there an ETA when this will be merged? |
Waiting for this as well, if I understand correctly this makes amplify compatible with expo 37 |
@DrWorkhard we were waiting for @react-native-community/async-storage to be supported in expo because redux-offline has a dependency on it, and and this change would not work in Expo without it. This just happened over the weekend: react-native-async-storage/async-storage#368 (comment) We will probably test the change in both bare and expo managed apps and then merge the PR later this week. |
Thank you so much, good to hear and keep up the great work! |
There are any way to apply this pull request for my projet? |
@Ashish-Nanda Any updates on timeframe? Looks like Expo SDK 38 just released with |
Any update on when this will be merged? Thanks! |
Hi, |
Tested apps generated with RN CLI & Expo with Verdaccio, and all seems to be working as expected 👍 |
Thanks for verifying @amhinson! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ashish-Nanda ! 👍
I don't understand, what is the fix for the issue? NPM install new aws packages? Which ones? |
@mikeRChambers610 Just install the latest aws-app sync package and you’ll have the fix. |
Issue #, if available:
Description of changes:
Upgrading redux-offline and netinfo dependencies for react native to use latest versions. This is because newer versions of NetInfo deprecated some APIs that were used by the version of redux-offline we were using.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.