Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocking calls #74

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Conversation

calavera
Copy link
Contributor

Description of changes:

There are currently two blocking calls that will prevent the adapter to utilize the Tokio scheduler correctly.

This change removes those calls by using Arc and AtomicBool when necessary.

Signed-off-by: David Calavera david.calavera@gmail.com

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

There are currently two blocking calls that will prevent the adapter to utilize the Tokio scheduler correctly.

This change removes those calls by using Arc and AtomicBoolwhen necessary.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera force-pushed the remove_blocking_calls branch from 7b4a9d1 to 20c0acc Compare September 10, 2022 23:49
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnusunny bnusunny merged commit 02ae98b into awslabs:main Sep 11, 2022
@calavera calavera deleted the remove_blocking_calls branch September 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants