fix readiness check function #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
approved these changes
Sep 8, 2022
calavera
reviewed
Sep 8, 2022
| @@ -95,20 +95,13 @@ impl Adapter { | |||
|
|
|||
| async fn check_readiness(&self) -> bool { | |||
There was a problem hiding this comment.
this function doesn't need to be async if the request blocks the thread.
calavera
reviewed
Sep 8, 2022
| @@ -95,20 +95,13 @@ impl Adapter { | |||
|
|
|||
| async fn check_readiness(&self) -> bool { | |||
| Retry::spawn(FixedInterval::from_millis(10), || { | |||
| let fut = self.check_health_url(); | |||
| async move { fut.await } | |||
| match reqwest::blocking::get(&self.healthcheck_url) { | |||
There was a problem hiding this comment.
any reason to use GET request and not HEAD? if the url you're checking is a homepage, the response could be really big. A HEAD request should work as well, without fetching the body.
There was a problem hiding this comment.
GET request allows the server to do additional actions, such as warm up cache and preload dependencies. HEAD request does not guarantee that. Servers might just return the headers and not do any extra actions.
I see the benefit of using HEAD request. We can make it an option for developers to choose. That should be another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new readiness check function error out on the first request to web server. The readiness check needs to retry the check repeatly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.