Lambda with Async/Await #111
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: Rust | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| - macOS-latest | ||
| rust: | ||
| - 1.40.0 | ||
| - stable | ||
| - beta | ||
| - nightly | ||
| target: | ||
| - "" | ||
| - x86_64-unknown-linux-musl | ||
| include: | ||
| - rust: nightly | ||
| allow_failure: true | ||
| exclude: | ||
| - os: macOS-latest | ||
| target: x86_64-unknown-linux-musl | ||
| - os: ubuntu-latest | ||
| rust: 1.40.0 | ||
| target: x86_64-unknown-linux-musl | ||
| - os: ubuntu-latest | ||
| rust: beta | ||
| target: x86_64-unknown-linux-musl | ||
| - os: ubuntu-latest | ||
| rust: nightly | ||
| target: x86_64-unknown-linux-musl | ||
| - os: macOS-latest | ||
| rust: 1.40.0 | ||
| - os: macOS-latest | ||
| rust: beta | ||
| - os: macOS-latest | ||
| rust: nightly | ||
| env: | ||
| RUST_BACKTRACE: 1 | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: ${{ matrix.rust }} | ||
| override: true | ||
| - name: Build | ||
| run: cargo build --all --verbose | ||
| env: | ||
| TARGET: ${{ matrix.target }} | ||
| continue-on-error: ${{ matrix.allow_failure }} | ||
| - name: Run tests | ||
| run: cargo test --all --verbose | ||
| env: | ||
| TARGET: ${{ matrix.target }} | ||
| continue-on-error: ${{ matrix.allow_failure }} | ||
| fmt: | ||
|
There was a problem hiding this comment. Yeah, I think we should add Clippy. |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: nightly | ||
| components: rustfmt | ||
| override: true | ||
| - name: Run fmt check | ||
| run: cargo fmt --all -- --check | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| edition = "2018" | ||
|
There was a problem hiding this comment. Didn't know this was a thing but heads up, rustfmt picks up the edition from your crate if invoked via cargo so you might not need this There was a problem hiding this comment. Yep, it normally should, but I think rust-analyzer didn't pick it up, but I think that was fixed. |
||
| # https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#merge_imports | ||
| merge_imports = true | ||
| # https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#max_width | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why fix to 1.40 instead of testing against stable? Do we plan to keep adding older versions here to ensure we maintain compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends: do we intend to have an minimum supported rust version?