Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SDK commit to use the latest SDK code #416

Merged
merged 36 commits into from
Dec 20, 2023
Merged

Updated SDK commit to use the latest SDK code #416

merged 36 commits into from
Dec 20, 2023

Conversation

HarshGandhi-AWS
Copy link
Contributor

@HarshGandhi-AWS HarshGandhi-AWS commented Jun 12, 2023 •
edited by RogerZhongAWS
Loading

Motivation

Modifications

Change summary

  • Updated SDK commit to use the latest SDK code.
  • Added support for new Secure Tunneling crt interface
  • Updated resource manager initializeAllocator method to public so it can be called from outside of SharedCrtResourceManager.
  • Added null check in SharedCrtResourceManager::disconnect method.
  • Updated unit test code to initialize allocator before using CRT library methods like CJSON or Crt::Map.
  • Reverted this change to avoid calling init twice when FP is enabled. https://github.com/awslabs/aws-iot-device-client/pull/391/files

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

  • Addressed reviewers comments
  • Added null check in SharedCrtResourceManager::disconnect method.
  • Updated unit test code to initialize allocator before using CRT library methods like CJSON or Crt::Map.

Testing

Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.

  • Manually tested changes locally
  • Ran CI tests
  • Ran Unit tests locally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

marcoemorais-aws
marcoemorais-aws previously requested changes Jun 12, 2023
View reviewed changes
source/main.cpp Outdated Show resolved Hide resolved
RogerZhongAWS
RogerZhongAWS reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@RogerZhongAWS RogerZhongAWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also may want to check if this line can be pulled out of buildClient()

https://github.com/awslabs/aws-iot-device-client/blob/239d10d968eb635d883998ff70e5054e66aef450/source/SharedCrtResourceManager.cpp#LL192C56-L192C56

marcoemorais-aws
marcoemorais-aws reviewed Jun 20, 2023
View reviewed changes
source/config/Config.cpp Outdated Show resolved Hide resolved
source/SharedCrtResourceManager.cpp Show resolved Hide resolved
marcoemorais-aws
marcoemorais-aws reviewed Jun 27, 2023
View reviewed changes
test/config/TestConfig.cpp Outdated
@@ -154,6 +156,8 @@ TEST_F(ConfigTestFixture, AllFeaturesEnabled)
"secure-element-token-label": "token-label"
}
})";
SharedCrtResourceManager resourceManager;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't one of these already initialized in ConfigTestFixture?

HarshGandhi-AWS and others added 9 commits July 5, 2023 13:43
@HarshGandhi-AWS
explicitly calling the code in SharedCrtManager to initialize allocat…
6eb723b 
…or and api handle. This will resolve the Sensor pullish unit tests which manually creates and initializes allocator and eventloop.
@HarshGandhi-AWS
addressed lint errors
926147b
@HarshGandhi-AWS
addressed lint errors
f9c50fe
@HarshGandhi-AWS
addressed reviewers comment and added the config serialization test back
0597270
@HarshGandhi-AWS
Update GTestMain.cpp to not cleanup resources after testing is completed
676882c 
This change will be reverted later. Added this to investigate DD integ test failure
@HarshGandhi-AWS
Update e2e-tests-ubutu-x86 test to skip secure tunneling test
f357df6
@marcoemorais-aws
Compile device client binaries as Release build type (#422)
95db8c9
@RogerZhongAWS
update sdk commit again
f50db70
@HarshGandhi-AWS
Updated code to shutdown on tunnel close callback and updated zlib de…
129f662 
…pendency version(#426)

* updated code to shutdown on tunnel close callback

* addressed lint errors
  
* addressed lint errors

* addressed lint errors

* updated zlib version

* updated zlib version

* updated comment
HarshGandhi-AWS and others added 11 commits October 3, 2023 10:08
@HarshGandhi-AWS
Updated Secure Tunneling close logic for Secure Tunneling Component (#…
d0e773d 
…427)

* Updated tunnel shutdown logic for Secure Tunneling component

* removed extra log statement
@HarshGandhi-AWS
Added null check before closing connection (#429)
6ee7ff9
@HarshGandhi-AWS
fixed bug to read SIGTERM signal when sent form kernal (#430)
f207eaf
@RogerZhongAWS @macano953
Fix docker-build.sh (#423)
af69d33 
There is an additional level of indirection required for the script to be able to build the container.

Co-authored-by: Miguel Cano <macano953@users.noreply.github.com>
@HarshGandhi-AWS
Updated google-test lib version to v1.12.0 (#431)
2efead6
@HarshGandhi-AWS
disabled jobs and secure tunneling if they are not compiled into bina…
b75dc3a 
…ry (#436)
@RogerZhongAWS
Update Dockerfile OpenSSL version (#435)
0f91380 
* Update Dockerfile

* Update README.md
@HarshGandhi-AWS
Removed number of slash validation for MQTT topics (#438)
00f68ce
@HarshGandhi-AWS
updated SDK again
7f569e9
@HarshGandhi-AWS
conflict fix
d11c527
@RogerZhongAWS
add http proxy support for secure tunneling
fb58d1f
@RogerZhongAWS RogerZhongAWS mentioned this pull request Dec 11, 2023
Closed
RogerZhongAWS
RogerZhongAWS previously approved these changes Dec 20, 2023
View reviewed changes
@HarshGandhi-AWS HarshGandhi-AWS dismissed RogerZhongAWS’s stale review December 20, 2023 01:59

The merge-base changed after approval.

RogerZhongAWS
RogerZhongAWS previously approved these changes Dec 20, 2023
View reviewed changes
@HarshGandhi-AWS HarshGandhi-AWS dismissed stale reviews from RogerZhongAWS and marcoemorais-aws December 20, 2023 19:07

The merge-base changed after approval.

@HarshGandhi-AWS HarshGandhi-AWS removed the request for review from marcoemorais-aws December 20, 2023 19:09
RogerZhongAWS
RogerZhongAWS previously approved these changes Dec 20, 2023
View reviewed changes
@HarshGandhi-AWS HarshGandhi-AWS dismissed RogerZhongAWS’s stale review December 20, 2023 19:13

The merge-base changed after approval.

@HarshGandhi-AWS HarshGandhi-AWS dismissed BolongZhang-AWS’s stale review December 20, 2023 19:19

The merge-base changed after approval.

BolongZhang-AWS
BolongZhang-AWS approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@BolongZhang-AWS BolongZhang-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship

@HarshGandhi-AWS HarshGandhi-AWS merged commit f4da551 into main Dec 20, 2023
70 of 73 checks passed
@HarshGandhi-AWS HarshGandhi-AWS deleted the updateSDKVersion branch December 20, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoemorais-aws marcoemorais-aws marcoemorais-aws left review comments

@BolongZhang-AWS BolongZhang-AWS BolongZhang-AWS approved these changes

@RogerZhongAWS RogerZhongAWS RogerZhongAWS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarshGandhi-AWS @BolongZhang-AWS @marcoemorais-aws @RogerZhongAWS