build wheel #50
Merged
build wheel #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jysheng123
force-pushed
the
build-wheels
branch
from
9e96350 to
d1b46f0
Compare
mndeveci
reviewed
Oct 4, 2023
hawflau
reviewed
Oct 5, 2023
hawflau
requested changes
Oct 5, 2023
jysheng123
force-pushed
the
build-wheels
branch
from
438fd54 to
9edd6a4
Compare
|
This PR is ready (if pass checks), but since its using docker/qemu action I am verifying with appsec engineer to make sure no security issues arise from this. |
…into build-wheels
jysheng123
force-pushed
the
build-wheels
branch
from
cdeb468 to
19209f8
Compare
jysheng123
commented
Oct 10, 2023
| CIBW_SKIP: "*-musllinux*" | ||
| CIBW_ENVIRONMENT_LINUX: GOARCH="${{ matrix.GO_ARCHITECTURE }}" | ||
| CIBW_ARCHS_LINUX: "${{matrix.LINUX_ARCHITECTURE}}" | ||
| CIBW_BEFORE_ALL_LINUX: |
There was a problem hiding this comment.
For context on why these commands are run: cibuildwheel documentation (https://cibuildwheel.readthedocs.io/en/stable/faq/), linux builds are held on its own containers which is why I am installing golang manually in the command line. However I had issues once inside the container running go so the workaround I did was to build the go binary in the container in the before all because golang works there and then in the actual building process, pass a flag to skip the binary building so go is not called at all and then the binary is then built.
hawflau
approved these changes
Oct 12, 2023
jysheng123
added a commit
that referenced
this pull request
Oct 17, 2023
* build wheel * add hash test * remove qemu non-linux * remove pull_request trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Added GH action for building wheels and publishing them to an artifact for future use. Note for linux builds, the GH action cibuildwheel has extra functionality to accommodate golang not being in the container and it builds the binary with golang before going in the container so inside setup.py it does not create a new binary if the env variable GO_ARCH is provided and uses the existing binary to create the wheel
Changes
User experience
Mandatory Checklist
If your change doesn't seem to apply, please leave them unchecked.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.