Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xray integ tests #29

Merged
merged 13 commits into from
Sep 5, 2023
Merged

Xray integ tests #29

merged 13 commits into from
Sep 5, 2023

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Aug 28, 2023

Issue number:
N/A

Summary

Adding integration test for "get_trace_tree" RPC Method.

Changes

  • Refactor CFN deploy and destroy stack to its own pkg for re-usability
  • Add integration test for "get_trace_tree"

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Mandatory Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hawflau hawflau marked this pull request as ready for review September 5, 2023 14:42
@hawflau hawflau requested a review from a team as a code owner September 5, 2023 14:42
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

s.T().Log("teardown suite complete")
}

func (s *GetTraceTreeSuite) TestPass() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this method be removed?

@hawflau hawflau added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit cbb1914 Sep 5, 2023
@hawflau hawflau deleted the xray-integ-tests branch September 7, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants