Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We made a change on aws/smithy-go#558 that changes the default for a Go project to generate a
go.mod
file by default. This broke the existing workflow on aws/aws-sdk-go-v2 sincegenerate
now fails withThis changes the line where we open the file to overwrite any existing content.
Testing
Setup
I created a fork of the repo since I wasn't able to get it to run locally. I then modified the copy codegen script to have the following
And ran
make
. Ensure clients get generated and tests pass successfully, with no meaningful diff.The main thing to consider is that all files now have this diff
Which I suspect should be fine since I think these files are just informative, but someone correct me if I'm wrong
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.