Fix generate params regions lookup + refactor pipeline management #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Opening this PR with four different changes that are heavily related.
Splitting these into different PRs would consume too much time unfortunately.
So please bear with me:
1. Generate params region lookup
With the changes introduced in PR Adding deployment map source to SSM params used to identify out of date pipelines #525, support was added for different deployment map providers.
This changed the location of the pipeline parameters to the scope of the source. In the case of our S3 deployment map provider, that changed:
/deployment/${pipeline_name}/regions
to/deployment/S3/${pipeline_name}/regions
.In the
generate_params.py
helper, it still continued to look for the regions in the original SSM Parameter Store location.2. Support debug logs in generate_params.py
generate_params.py
efficiently.3. Merge in default deployment props into target specifications
4. S3 Extract property default not defined
What?
1. Generate params region lookup
input
topipeline_input
to clearly indicate what input we are referring to.deployment_map_source
anddeployment_map_name
context to the ADF Pipeline Management state machine.${bootstrap_repo}/adf-build/shared/cdk/generate_pipeline_inputs.py
as that is replaced by the ADF Pipeline Management using the Step Function state machine instead.2. Support debug logs in generate_params.py
ADF_LOG_LEVEL
environment variable and set it toDEBUG
to get the logs printed.3. Merge in default deployment props into target specifications
4. S3 Extract property default not defined
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.