Improve adf-pipelines CodeBuild permissions kickstarting SFN #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** With the move to Step Functions, the majority of the workload for the adf-pipelines CodeBuild process was moved to the ADF Pipeline Management State Machine in AWS Step Functions. However, the policies attached to the original CodeBuild environment were not updated yet. Additionally, the machine type used for this process could be reduced in size too. **What?** * Changed the name from `pipeline-provisioner*` to `pipeline-generation-provisioner*`, as it no longer privisions the pipelines but ensures the Step Function has the required input to do it instead. * Removed the original provisioner role from AssumeRole permissions that it no longer requires. * Removed environment variables that are not used by the process to provision the pipeline generator. * Removed policy statements that the pipeline-generation provisioner does not require. * Applied the `/adf-automation/` path to the pipeline-generation provisioner role.
javydekoning
approved these changes
Dec 14, 2022
StewartW
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
With the move to Step Functions, the majority of the workload for the adf-pipelines CodeBuild process was moved to the ADF Pipeline Management State Machine in AWS Step Functions.
However, the policies attached to the original CodeBuild environment were not updated yet. Additionally, the machine type used for this process could be reduced in size too.
What?
pipeline-provisioner*topipeline-generation-provisioner*, as it no longer privisions the pipelines but ensures the Step Function has the required input to do it instead./adf-automation/path to the pipeline-generation provisioner role.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.