Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yamllint detected error #494

Closed
wants to merge 1 commit into from

Conversation

nvuillam
Copy link

@nvuillam nvuillam commented Aug 22, 2022

Fix issue detected by yamllint during MegaLinter process

There are also cfn-lint issues, but as I'm no Cloudformation expert, I don't know how to solve them ^^

E0002 Unknown exception while processing rule E2001: local variable 'reqname' referenced before assignment
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:1:1

E1001 Missing top level template section Resources
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:1:1

E1001 Top level template section Version is not valid
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:2:3

W2001 Parameter RuleName not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:4:5

W2001 Parameter Description not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:5:5

W2001 Parameter SourceRuntime not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:6:5

W2001 Parameter CodeKey not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:7:5

W2001 Parameter InputParameters not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:8:5

W2001 Parameter OptionalParameters not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:9:5

W2001 Parameter SourceEvents not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:10:5

W2001 Parameter SourcePeriodic not used.
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:11:5

E1001 Top level template section Tags is not valid
/github/workspace/samples/sample-rdk-rules/config-rules/EC2_CHECKS_TERMINIATION_PROTECTION_ADF/parameters.json:13:3

E1001 Missing top level template section Resources
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:1:1

E1001 Top level template section Type is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:3:3

E1001 Top level template section DependsOn is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:4:3

E1001 Top level template section Properties is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:5:3

E1012 Ref SourceBucket not found as a resource or parameter
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:8:7

E1010 Invalid GetAtt RuleNameStrippedLambdaRole.Arn for resource Role
/github/workspace/samples/sample-rdk-rules/templates/lambda-function.json:17:7

E1001 Missing top level template section Resources
/github/workspace/samples/sample-rdk-rules/templates/lambda-permission.json:1:1

E1001 Top level template section Type is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-permission.json:3:3

E1001 Top level template section DependsOn is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-permission.json:4:3

E1001 Top level template section Properties is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-permission.json:5:3

E1010 Invalid GetAtt RuleNameStrippedLambdaFunction.Arn for resource FunctionName
/github/workspace/samples/sample-rdk-rules/templates/lambda-permission.json:7:7

E1001 Missing top level template section Resources
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:1:1

E1001 Top level template section Type is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:3:3

E1001 Top level template section Properties is not valid
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:4:3

E1019 Parameter SourceBucket for Fn::Sub not found at Properties/Policies/0/PolicyDocument/Statement/0/Resource/Fn::Sub
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:32:17

E1019 Parameter SourceBucketFolder for Fn::Sub not found at Properties/Policies/0/PolicyDocument/Statement/0/Resource/Fn::Sub
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:32:17

W1020 Fn::Sub isn't needed because there are no variables at Properties/ManagedPolicyArns/0/Fn::Sub
/github/workspace/samples/sample-rdk-rules/templates/lambda-role.json:78:9

@javydekoning
Copy link
Contributor

All linter issues are addressed in #495 , hence closing this PR. TY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants