Move account process to main SAR template #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. |
StewartW
previously approved these changes
Aug 17, 2022
**Why?** The SAR does not understand local references as introduced by the src/account_processing.yml unfortunately. **What?** After investigating several options, the only option that was accepted was to move the logic inside the main template instead. The references are updated to use the ones available in the main template directly. Additionally, the ARN references are updated to include the partition correctly.
Removed from the CloudFormation Linter configuration and removed the file itself. I've added this as a separate commit to make it easier to check the differences between the `src/account_processing.yml` and the resources that it contained that were moved to the `src/template.yml` file.
sbkok
force-pushed
the
fix/account-mgmt-state-machine
branch
from
36be269
to
738c5ca
Compare
|
(Rebased on the latest commit in master to resolve a conflict) |
StewartW
previously approved these changes
Aug 19, 2022
|
@javydekoning and @StewartW, I had to resolve a merge conflict. Unfortunately that dismissed the review approvals. |
javydekoning
approved these changes
Aug 23, 2022
StewartW
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The SAR does not understand local references as introduced by the
src/account_processing.ymlunfortunately.What?
After investigating several options, the only option that was accepted was to move the logic inside the main template instead. The references are updated to use the ones available in the main template directly.
Additionally, the ARN references are updated to include the partition correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.