Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CDK v1.137, pylint v2.12, and others to latest available #417

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

sbkok
Copy link
Collaborator

@sbkok sbkok commented Dec 24, 2021

Bumping versions of CDK, pylint, SAM CLI, Boto3, and other libraries that we depend on.

The update of pylint returned a list of errors, as shown below.
These errors have been fixed as part of this commit.

Additionally, I refactored code that could use a refreshing haircut.


find src/ -iname "*.py" -not -path "src/.aws-sam/*" | xargs pylint --rcfile .pylintrc
************* Module lambda_codebase.event
src/lambda_codebase/event.py:25:39: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module lambda_codebase.account_bootstrap
src/lambda_codebase/account_bootstrap.py:54:69: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/account_bootstrap.py:55:73: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/account_bootstrap.py:58:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module lambda_codebase.wait_until_complete
src/lambda_codebase/wait_until_complete.py:46:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/wait_until_complete.py:50:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/wait_until_complete.py:86:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/wait_until_complete.py:96:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module lambda_codebase.enable_cross_account_access
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/enable_cross_account_access.py:62:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/enable_cross_account_access.py:66:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module initial_commit
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/initial_commit/initial_commit.py:140:17: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/initial_commit/initial_commit.py:157:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module lambda_codebase.update_pipelines
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/update_pipelines.py:28:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module lambda_codebase.slack
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:25:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:32:34: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:78:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:85:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:90:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:104:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:123:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:145:13: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-bootstrap/deployment/lambda_codebase/slack.py:149:63: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.config
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/config.py:89:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.organization_policy
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/organization_policy.py:26:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/organization_policy.py:196:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.generate_pipeline_inputs
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:61:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:69:8: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:81:50: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:82:51: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:127:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_inputs.py:127:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_stacks.adf_default_pipeline
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:201:33: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:209:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:223:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:231:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:239:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:247:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:255:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:263:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:271:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py:279:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.clean_pipelines
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/clean_pipelines.py:55:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.generate_pipeline_stacks
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/generate_pipeline_stacks.py:30:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.shared.cdk.cdk_constructs.adf_codecommit
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codecommit.py:24:17: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_constructs.adf_cloudformation
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:30:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:38:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:44:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:51:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:56:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_cloudformation.py:64:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_constructs.adf_codebuild
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:62:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:63:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:69:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:72:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:76:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:100:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:101:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:126:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:155:23: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.py:173:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_constructs.adf_events
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:46:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:80:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:81:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:91:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:104:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:118:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:119:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:127:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:139:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:152:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_events.py:153:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_constructs.adf_codepipeline
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:87:82: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:181:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:182:30: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:192:53: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:194:33: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:195:41: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:202:27: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:205:41: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:218:41: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:224:43: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:231:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:232:64: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:233:49: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:234:53: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:248:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:254:109: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:291:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:323:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:367:15: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:403:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py:444:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.cdk_constructs.adf_github
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_github.py:58:33: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_github.py:62:17: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.cdk.execute_pipeline_stacks
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/execute_pipeline_stacks.py:39:35: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/execute_pipeline_stacks.py:52:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/execute_pipeline_stacks.py:74:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.shared.python.parameter_store
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/parameter_store.py:66:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/parameter_store.py:82:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.python.cloudformation
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py:64:15: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py:70:15: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py:90:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py:129:39: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/cloudformation.py:264:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.python.stepfunctions
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/stepfunctions.py:108:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.python.rule
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/rule.py:32:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/rule.py:43:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.python.organizations
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:76:62: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:83:62: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:98:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:99:17: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:112:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:112:18: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:128:55: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:199:15: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py:234:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.python.s3
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:43:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:48:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:53:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:58:29: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:60:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:66:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:72:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:167:23: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py:171:19: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.generate_params
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:43:36: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:47:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:54:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:67:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:67:72: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:71:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:77:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:82:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:87:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:96:56: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:108:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:108:22: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:112:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:112:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:124:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/generate_params.py:124:18: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.deployment_map
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:45:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:45:18: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:48:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:51:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:55:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/deployment_map.py:66:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.shared.pipeline
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/pipeline.py:33:17: R1734: Consider using [] instead of list() (use-list-literal)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/pipeline.py:43:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/pipeline.py:48:22: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/pipeline.py:49:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.shared.resolver
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:42:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:79:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:103:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:115:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:123:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:124:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:130:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:131:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:158:41: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/resolver.py:168:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.repo
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/repo.py:34:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/repo.py:39:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/repo.py:64:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module adf-build.shared.target
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/target.py:104:39: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/target.py:171:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module retrieve_organization_accounts
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/helpers/retrieve_organization_accounts.py:203:15: R1734: Consider using [] instead of list() (use-list-literal)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/helpers/retrieve_organization_accounts.py:240:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module src.configparser
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/provisioner/src/configparser.py:33:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module adf-build.main
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/main.py:49:15: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/main.py:92:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/main.py:96:12: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/initial_commit.py:144:17: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/initial_commit.py:161:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/initial_commit.py:340:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
src/lambda_codebase/initial_commit/initial_commit.py:348:24: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
************* Module main
src/lambda_codebase/account/main.py:162:28: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)

-----------------------------------
Your code has been rated at 9.55/10

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Bumping versions of CDK, SAM CLI, Boto3, and other libraries that we
depend on.
The update of pylint returned a list of errors.
These errors have been fixed as part of this commit.

Additionally, refactored code that could use a refreshing haircut.
@sbkok sbkok added the enhancement New feature or request label Dec 24, 2021
@sbkok sbkok added this to the v3.2.0 milestone Dec 24, 2021
Copy link
Contributor

@StewartW StewartW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer! Thanks 🥇

Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sbkok sbkok merged commit 6cabcf7 into awslabs:master Jan 7, 2022
@sbkok sbkok deleted the chore/upgrade-versions branch January 7, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants