Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message with accounts yml read failures #403

Merged
merged 4 commits into from
Nov 12, 2021

Conversation

sbkok
Copy link
Collaborator

@sbkok sbkok commented Nov 9, 2021

Why?

As reported in #213, an empty YAML file would result in an error message that is hard to debug.

What?

Updated the error reporting to indicate what file was read and what error occurred.
Allowing our users to debug the issue quicker.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

**Why?**

As reported in awslabs#213, an empty YAML file would result in an error message
that is hard to debug.

**What?**

Updated the error reporting to indicate what file was read and what
error occurred. Allowing our users to debug the issue quicker.
@sbkok sbkok added this to the v3.2.0 milestone Nov 9, 2021
@sbkok sbkok added the enhancement New feature or request label Nov 9, 2021
StewartW
StewartW previously approved these changes Nov 9, 2021
Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sbkok sbkok requested a review from StewartW November 12, 2021 11:21
Copy link
Contributor

@StewartW StewartW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sbkok sbkok merged commit 8a9ffbe into awslabs:master Nov 12, 2021
@sbkok sbkok deleted the fix/accounts-yaml-parser-error-msg branch November 12, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants