Lock down buckets created by ADF - block public access #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** By default, ADF does not mark any object or bucket to be accessibly publicly. However, the buckets did not restrict any other process from doing so anyway. **What?** To ensure objects are not accidentally made public, this change will enforce that. Changing the object or bucket policies to public would not be allowed. Additionally, one bucket, the BootstrapArtifactStorageBucket that was added recently by awslabs#270 did not configure encryption and versioning. This was not released as part of ADF yet, so no data was exposed. The samples that deployed buckets are also updated to include the encryption, versioning, and block-public access properties.
deltagarrett
approved these changes
Apr 12, 2021
thomasmcgannon
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
LGTM, assuming line 778 with version is being replaced in #351 with the metadata tag?
|
@thomasmcgannon Correct, I will patch that in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
By default, ADF does not mark any object or bucket to be accessibly
publicly. However, the buckets did not restrict any other process from
doing so anyway.
What?
To ensure objects are not accidentally made public, this change will
enforce that. Changing the object or bucket policies to public would not
be allowed.
Additionally, one bucket, the
BootstrapArtifactStorageBucketthat wasadded recently by #270 did not configure encryption and versioning.
This was not released as part of ADF yet, so no data was exposed.
The samples that deployed buckets are also updated to include the
encryption, versioning, and block-public access properties.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.