Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject more characters from a CloudFormation Stack name #346

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Reject more characters from a CloudFormation Stack name #346

merged 2 commits into from
Apr 9, 2021

Conversation

benbridts
Copy link
Contributor

We are running into this with an OU that has a . in the name.

I used the constraints found on https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

@deltagarrett deltagarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbkok sbkok merged commit b5b333d into awslabs:master Apr 9, 2021
@sbkok sbkok added this to the v3.2.0 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants