Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload function using s3-uri or s3-url fails #299

Closed
hynynen opened this issue Oct 21, 2020 · 1 comment · Fixed by #329
Closed

Upload function using s3-uri or s3-url fails #299

hynynen opened this issue Oct 21, 2020 · 1 comment · Fixed by #329
Assignees
Milestone

Comments

@hynynen
Copy link

hynynen commented Oct 21, 2020

I have this parameters file global.yml

Parameters:
    FlowLogsRetention: '30'
    S3BucketFlowLogs: "someFLowLogsBucket"
    IPAMFunctionCode: upload:s3-url:ipam.zip

Mechanism is introduced here: https://github.com/awslabs/aws-deployment-framework/blob/master/docs/user-guide.md#uploading-assets

My pipeline fails at build stage:


[Container] 2020/10/21 13:46:24 Running command python adf-build/generate_params.py
--
22 | Traceback (most recent call last):
23 | File "adf-build/generate_params.py", line 166, in <module>
24 | main()
25 | File "adf-build/generate_params.py", line 162, in main
26 | parameters.create_parameter_files()
27 | File "adf-build/generate_params.py", line 88, in create_parameter_files
28 | compare_params
29 | File "adf-build/generate_params.py", line 148, in _param_updater
30 | self._determine_parameter_structure(comparison_parameters, resolver)
31 | File "adf-build/generate_params.py", line 135, in _determine_parameter_structure
32 | return self._determine_parameter_structure(value, resolver)
33 | File "adf-build/generate_params.py", line 136, in _determine_parameter_structure
34 | if self._determine_intrinsic_function(resolver, value, key):
35 | File "adf-build/generate_params.py", line 127, in _determine_intrinsic_function
36 | return resolver.upload(value, key, self.file_name)
37 | File "/codebuild/output/src590690604/src/adf-build/resolver.py", line 101, in upload
38 | ) from None
39 | Exception: When uploading to S3 you need to specify a pathing style for the response either path or virtual-hosted, read more: https://docs.aws.amazon.com/AmazonS3/latest/dev/VirtualHosting.html
@sbkok sbkok self-assigned this Dec 30, 2020
@sbkok
Copy link
Collaborator

sbkok commented Dec 30, 2020

Hi Henry,

Apologies for the late reply. This issue will be fixed with the next release of ADF, v3.1.0.
It was fixed in PR: #275, but that fix is not released as a new ADF version yet.
I will keep this issue open until it is released officially.

Best regards, Simon

@sbkok sbkok added this to the v3.1.0 milestone Dec 30, 2020
sbkok added a commit to sbkok/aws-deployment-framework that referenced this issue Feb 12, 2021
**Features 🏗**

* Adds Enterprise Support to account creation process awslabs#233, closes awslabs#232:
  * ADF will raise a ticket to add the account to an existing AWS support subscription when an account is created. As a prerequisite, your organization master account must already have enterprise support activated.
* Adds nested deployment map support awslabs#266 and awslabs#328, closes awslabs#265:
  * This enables usage of sub directories within the deployment_maps folder.

**Fixes 🐞**

* Fixes specific role usage to be used in Build and Deploy only awslabs#295.
* Corrects removing pipelines anchor in docs awslabs#279.
* Fixes CI builds due to isort version mismatch awslabs#284.
* Fixes error handling of generate_params intrinsic upload function awslabs#277, closes awslabs#276.
* Fixes spec_inline attribute of CodeBuild in docs awslabs#289.
* Fixes provider spec_inline support of CodeBuild in awslabs#293.
* Fixes supported list of intrinsic upload path styles, enables usage of s3-url and s3-key-only awslabs#275, closes awslabs#299.
* Fixes create deployment account concurrency failure awslabs#287, closes awslabs#280.
* Fixes approval stage usage, by limiting specific role usage to Build and Deploy steps awslabs#295.
* Fixes yarnpkg GPG awslabs#313,  closes awslabs#325.
* Removes dependency on botocore.vendored.requests awslabs#326, closes awslabs#324.

**Improvements ✨**

* Improves docs on providers and their properties awslabs#274.
* Separates pipeline cleanup from input generation script awslabs#288.
* Upgrades Python from v3.7 to v3.8 awslabs#313.
* Upgrades CodeBuild image from "aws/codebuild/standard:2.0" to "aws/codebuild/standard:5.0" awslabs#313, closes awslabs#267, closes awslabs#300.
* Upgrades CDK from v1.32 to v1.88 awslabs#313, closes awslabs#292.
@sbkok sbkok mentioned this issue Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants