Skip to content

Commit

Permalink
Fix bug where last few bytes on socket go unread (#269)
Browse files Browse the repository at this point in the history 
**Issue:**

We see occasional errors when the server sends an HTTP response with a `Connection: close` header (meaning it intends to close the connection after the response is sent). The server is sending the full response, then immediately hanging up. But the last few bytes of the response never make it to the HTTP client.

**Description of changes:**

Update submodules, bringing in this fix: awslabs/aws-c-io#642
```
aws-c-auth         v0.7.16 -> v0.7.22
aws-c-cal          v0.6.10 -> v0.6.15
aws-c-common       v0.9.14 -> v0.9.21
aws-c-http         v0.8.1 -> v0.8.2
aws-c-io           v0.14.6 -> v0.14.9
aws-c-sdkutils     v0.1.15 -> v0.1.16
s2n                v1.4.8 -> v1.4.16
```
  • Loading branch information
@graebm
graebm committed Jun 12, 2024
1 parent b6380f6 commit 4719842
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-auth
Submodule aws-c-auth updated 21 files
+1 −0 include/aws/auth/auth.h
+86 −18 include/aws/auth/credentials.h
+20 −0 include/aws/auth/private/credentials_utils.h
+5 −2 source/auth.c
+1 −1 source/credentials_provider_cognito.c
+25 −73 source/credentials_provider_default_chain.c
+162 −9 source/credentials_provider_ecs.c
+11 −0 source/credentials_provider_environment.c
+25 −0 source/credentials_provider_imds.c
+34 −1 source/credentials_provider_profile.c
+7 −40 source/credentials_provider_sso.c
+105 −31 source/credentials_provider_sts.c
+32 −59 source/credentials_provider_sts_web_identity.c
+65 −0 source/credentials_utils.c
+6 −0 tests/CMakeLists.txt
+0 −12 tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/context.json
+0 −2 tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/request.txt
+0 −12 tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/context.json
+0 −2 tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/request.txt
+397 −43 tests/credentials_provider_ecs_tests.c
+527 −60 tests/credentials_provider_sts_tests.c
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-cal
Submodule aws-c-cal updated 17 files
+22 −5 .github/workflows/ci.yml
+7 −1 CMakeLists.txt
+1 −9 bin/produce_x_platform_fuzz_corpus/CMakeLists.txt
+1 −9 bin/run_x_platform_fuzz_corpus/CMakeLists.txt
+1 −9 bin/sha256_profile/CMakeLists.txt
+16 −2 builder.json
+9 −0 include/aws/cal/private/symmetric_cipher_priv.h
+12 −1 include/aws/cal/symmetric_cipher.h
+14 −14 source/darwin/commoncrypto_aes.c
+1 −0 source/darwin/securityframework_ecc.c
+5 −0 source/rsa.c
+20 −8 source/symmetric_cipher.c
+29 −17 source/unix/openssl_aes.c
+29 −7 source/unix/openssl_platform_init.c
+22 −19 source/windows/bcrypt_aes.c
+1 −0 tests/CMakeLists.txt
+88 −0 tests/aes256_test.c
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-common
Submodule aws-c-common updated 47 files
+1 −1 .github/workflows/ci.yml
+10 −10 CMakeLists.txt
+1 −1 README.md
+14 −0 bin/system_info/print_system_info.c
+13 −0 cmake/AwsFeatureTests.cmake
+73 −24 cmake/AwsSIMD.cmake
+1 −0 cmake/AwsTestHarness.cmake
+64 −16 include/aws/common/atomics_msvc.inl
+7 −0 include/aws/common/config.h.in
+2 −0 include/aws/common/cpuid.h
+14 −0 include/aws/common/hash_table.h
+28 −0 include/aws/common/host_utils.h
+5 −0 include/aws/common/linked_list.h
+4 −0 include/aws/common/linked_list.inl
+1 −1 include/aws/common/package.h
+0 −103 include/aws/common/promise.h
+12 −24 include/aws/testing/aws_test_harness.h
+7 −1 source/arch/arm/auxv/cpuid.c
+40 −0 source/arch/arm/darwin/cpuid.c
+11 −2 source/arch/arm/windows/cpuid.c
+2 −2 source/arch/intel/cpuid.c
+4 −4 source/arch/intel/encoding_avx2.c
+6 −3 source/array_list.c
+2 −2 source/encoding.c
+17 −3 source/external/cJSON.c
+1 −1 source/external/cJSON.h
+8 −0 source/hash_table.c
+114 −0 source/host_utils.c
+37 −22 source/memtrace.c
+16 −3 source/posix/thread.c
+0 −118 source/promise.c
+2 −5 source/string.c
+3 −3 source/task_scheduler.c
+15 −6 source/uri.c
+4 −6 tests/CMakeLists.txt
+2 −2 tests/atomics_test.c
+73 −0 tests/host_util_test.c
+23 −0 tests/linked_list_test.c
+12 −8 tests/memtrace_test.c
+0 −181 tests/promise_test.c
+35 −1 tests/thread_test.c
+2 −2 tests/uri_test.c
+1 −1 verification/cbmc/include/proof_helpers/aws_byte_cursor_read_common.h
+1 −1 verification/cbmc/include/proof_helpers/make_common_data_structures.h
+8 −8 verification/cbmc/include/proof_helpers/nondet.h
+1 −1 verification/cbmc/sources/make_common_data_structures.c
+1 −1 verification/cbmc/stubs/abort_override_assert_false.c
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-http
Submodule aws-c-http updated 2 files
+5 −4 tests/CMakeLists.txt
+41 −1 tests/test_h1_client.c
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-io
Submodule aws-c-io updated 21 files
+2 −1 include/aws/io/tls_channel_handler.h
+4 −1 source/future.c
+17 −13 source/posix/socket.c
+29 −2 source/s2n/s2n_tls_channel_handler.c
+40 −21 source/socket_channel_handler.c
+2 −1 source/windows/iocp/socket.c
+29 −5 tests/CMakeLists.txt
+97 −0 tests/default_host_resolver_test.c
+23 −0 tests/future_test.c
+34 −16 tests/read_write_test_handler.c
+7 −0 tests/read_write_test_handler.h
+15 −15 tests/resources/ca_root.crt
+4 −4 tests/resources/ec_unittests.crt
+ − tests/resources/ec_unittests.p12
+15 −15 tests/resources/server.crt
+25 −25 tests/resources/server.key
+30 −30 tests/resources/server_chain.crt
+8 −8 tests/resources/unittests.crt
+ − tests/resources/unittests.p12
+314 −93 tests/socket_handler_test.c
+3 −1 tests/socket_test.c
2 changes: 1 addition & 1 deletion aws-common-runtime/aws-c-sdkutils
Submodule aws-c-sdkutils updated 5 files
+0 −11 include/aws/sdkutils/private/endpoints_util.h
+3 −2 source/endpoints_standard_lib.c
+0 −120 source/endpoints_util.c
+0 −2 tests/CMakeLists.txt
+0 −59 tests/endpoints_util_tests.c
2 changes: 1 addition & 1 deletion aws-common-runtime/s2n
Submodule s2n updated 196 files

0 comments on commit 4719842

Please sign in to comment.