feat(aws-codepipeline): make input Artifacts explicit when creating Actions #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at this, I am having second thoughts about this change. What value do we add by complicating the API and making it more verbose. We have a design tenet to only require configuration when we can’t deduce it automatic (“smart defaults”) and when I am looking at this change I think it violates this tenet by asking users to add a lot of configuration that can easily be safely reduced from their intent. |
skinny85
force-pushed
the
feature/explicit-pipeline-artifacts
branch
from
130f81b
to
0e2f1f1
Compare
|
Rebased on top of the new |
…ctions. BREAKING CHANGE: previously, the CodePipeline Construct would attempt to wire the inputs of Actions implicitly, if they were not provided. Now, this functionality has been removed, and we require specifying the inputs for Build, Test and Deploy Actions explicitly.
skinny85
force-pushed
the
feature/explicit-pipeline-artifacts
branch
from
0e2f1f1
to
a536086
Compare
|
Missed a test in the |
|
The PR has languished for too long and now it needs to merge. |
4 tasks
|
This PR is currently superseded by #1590. |
|
Yep. Check out the comment right above yours :). |
|
LOL. Let's close it? |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: previously, the CodePipeline Construct would attempt
to wire the inputs of Actions implicitly, if they were not provided.
Now, this functionality has been removed, and we require specifying the
inputs for Build, Test and Deploy Actions explicitly.
Part of the agreed upon changes to the CodePipeline Construct library.
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.