Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-apigateway): RestApi to use logical id as a name for APIs instrea of name of current construct #2957

Closed
julienlepine opened this issue Jun 20, 2019 · 1 comment · Fixed by #2960
Closed

feat(aws-apigateway): RestApi to use logical id as a name for APIs instrea of name of current construct #2957

julienlepine opened this issue Jun 20, 2019 · 1 comment · Fixed by #2960
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.

Comments

@julienlepine
Copy link
Contributor

When creating a Rest API inside a construct, the name attribute of the newly created AWS::ApiGateway::RestApi is based only on the id of the apigw.RestApi entry.

This limits discoverability when a Stack has multiple APIs. Having a name that would be equal to the LogicalId of the created CloudFormation resource would simplify discoverability.
@julienlepine julienlepine added the feature-request A feature should be added or improved. label Jun 20, 2019
@julienlepine julienlepine mentioned this issue Jun 20, 2019
Merged
4 tasks
@NGL321 NGL321 added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Jun 21, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 21, 2019

Hi Julien! Thank you so much for contributing. We are working hard to stabilize the CDK APIs and tuning them to meet our consistency guidelines. While we work on getting the APIs aligned with our guidelines, we are pausing work on most community PRs starting around the 21st of this month. Please continue to report issues and submit feature requests, of course. We expect to get back to work on community PRs within a few weeks.

eladb pushed a commit that referenced this issue Jun 27, 2019
@julienlepine
feat(aws-apigateway): expand RestApi support to models, parameters an…
12e6380 
…d validators (#2960)

Fixes #905: "apigateway: "methodResponses" is missing from MethodOptions"
Fixes #1695: apigateway: missing support for models
Fixes #727: API Gateway: improve API for request parameters and responses
Fixes #723: API Gateway: missing features
Fixes #2957: RestApi to use logical id as a name for APIs instead of name of current construct
Adds support for JsonSchema in Model
Aligns Model to the PhysicalName convention.
No breaking change, documentation updated
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-apigateway): expand RestApi support to models, parameters and validators
2 participants
@julienlepine @NGL321