Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apigateway: missing support for models #1695

Closed
john-shaskin opened this issue Feb 6, 2019 · 5 comments · Fixed by #2960
Closed

apigateway: missing support for models #1695

john-shaskin opened this issue Feb 6, 2019 · 5 comments · Fixed by #2960
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.

Comments

@john-shaskin
Copy link
Contributor

When defining a REST API with API gateway, we can't currently define a collection of models that can be used to map response payloads from an integration to what is returned to a client.

https://docs.aws.amazon.com/apigateway/latest/developerguide/models-mappings.html

#1572 introduces the base support for MethodResponses, but only gives the functionality to use the default provided Empty and Error models that are generated, when you create a REST API. This work should be continued to provide full support for defining models.
@eladb eladb added feature-request A feature should be added or improved. @aws-cdk/aws-apigateway Related to Amazon API Gateway labels Feb 11, 2019
@john-shaskin
Copy link
Contributor Author

Starting to look into this one.

@eladb
Copy link
Contributor

eladb commented Feb 28, 2019

👍

@john-shaskin
Copy link
Contributor Author

I've been slow at working on this. Think I've got most of the changes sorted out. Just trying to wrap enough testing around creating and consuming models. Will try to get a PR open soon, to get some discussion going.

@eladb
Copy link
Contributor

eladb commented Mar 20, 2019

Thanks for the update! Looking forward

@john-shaskin john-shaskin mentioned this issue Mar 27, 2019
Closed
4 tasks
@john-shaskin
Copy link
Contributor Author

PR #2102 has been opened to address this issue.

@julienlepine julienlepine mentioned this issue Jun 20, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue Jun 27, 2019
@julienlepine
feat(aws-apigateway): expand RestApi support to models, parameters an…
12e6380 
…d validators (#2960)

Fixes #905: "apigateway: "methodResponses" is missing from MethodOptions"
Fixes #1695: apigateway: missing support for models
Fixes #727: API Gateway: improve API for request parameters and responses
Fixes #723: API Gateway: missing features
Fixes #2957: RestApi to use logical id as a name for APIs instead of name of current construct
Adds support for JsonSchema in Model
Aligns Model to the PhysicalName convention.
No breaking change, documentation updated
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jan 20, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Jan 20, 2020
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-apigateway): expand RestApi support to models, parameters and validators
2 participants
@eladb @john-shaskin