-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs: set the default value of HealthCheckGracePeriodSeconds
to 60 seconds
#2936
Closed
hencrice opened this issue
Jun 19, 2019
· 0 comments
· Fixed by #2942 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
ecs: set the default value of HealthCheckGracePeriodSeconds
to 60 seconds
#2936
hencrice opened this issue
Jun 19, 2019
· 0 comments
· Fixed by #2942 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
feature-request
A feature should be added or improved.
Comments
3 tasks
rix0rrr
pushed a commit
that referenced
this issue
Jun 21, 2019
Set the default `HealthCheckGracePeriodSeconds` in base-service to 60 seconds if it's not already set and at least one load balancer is configured This was a FIXME in the ECS CDK codebase. Closes #2936.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
feature-request
A feature should be added or improved.
This is intended for the
FIXME
comment https://github.com/hencrice/aws-cdk/blob/master/packages/%40aws-cdk/aws-ecs/lib/base/base-service.ts#L67. This was brought up as an action item in the ECS CDK API review.I checked with our team and they seem to think 60 seconds is a sensible starting point. The default should only kicks in if
HealthCheckGracePeriodSeconds
is not already set by customers and at least one LB is configured.The text was updated successfully, but these errors were encountered: