feat(ecs): set default HealthCheckGracePeriodSeconds
#2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice to 60 seconds if it's not already set and at least one load balancer is configured This was a FIXME in the ECS CDK codebase. Closes #2936.
SoManyHs
changed the title
HealthCheckGracePeriodSeconds in base-se…HealthCheckGracePeriodSeconds
SoManyHs
changed the title
HealthCheckGracePeriodSeconds HealthCheckGracePeriodSeconds
eladb
reviewed
Jun 20, 2019
| healthCheckGracePeriodSeconds: props.healthCheckGracePeriodSeconds, | ||
| // only set the grace period when load balancers are configured and | ||
| // healthCheckGracePeriodSeconds is not already set | ||
| healthCheckGracePeriodSeconds: Lazy.anyValue({ produce: () => |
There was a problem hiding this comment.
Can we move this to a helper private method for readability?
|
|
@pkandasamy91 |
# Conflicts: # packages/@aws-cdk/aws-ecs/lib/base/base-service.ts
…econds` into a private helper method as requested
|
@rix0rrr Could you give me console access to the AWS account you guys are using for the "AWS CodeBuild us-east-1" check. Otherwise I can't see what's causing the check to fail. Thanks! |
rix0rrr
reviewed
Jun 21, 2019
| healthCheckGracePeriodSeconds: props.healthCheckGracePeriodSeconds, | ||
| // only set the grace period when load balancers are configured and | ||
| // healthCheckGracePeriodSeconds is not already set | ||
| healthCheckGracePeriodSeconds: Lazy.anyValue({ produce: () => |
There was a problem hiding this comment.
Could be a Lazy.numberValue(), no?
| // only set the grace period when load balancers are configured and | ||
| // healthCheckGracePeriodSeconds is not already set | ||
| healthCheckGracePeriodSeconds: Lazy.anyValue({ produce: () => | ||
| this.loadBalancers |
There was a problem hiding this comment.
this.loadBalancers should never be undefined. Should we not make the default an empty array? Gets rid of the test here.
rix0rrr
approved these changes
Jun 21, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default HealthCheckGracePeriodSeconds in BaseService to 60 seconds if it's not already set and at least one load balancer is configured.
Closes #2936.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.