-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecs: Rename hwType
in EcsOptimizedAmiProps
interface to hardwareType
#2896
ecs: Rename hwType
in EcsOptimizedAmiProps
interface to hardwareType
#2896
Comments
Hi Yenlin, thank you for following the contribution guidelines and creating an issue for your changes! However, the purpose behind that rule is to justify the changes you are making. |
Hey Noah, This suggestion came from an ECS-internal API review. I'm following the guideline here for contribution: https://github.com/awslabs/aws-cdk/blob/master/CONTRIBUTING.md and that was why I created this issue. |
This change spells out the previously abbreviated `hwType` into `hardwareType` and it closes #2896. BREAKING CHANGE: * **ecs**: the property that specifies the type of EC2 AMI optimized for ECS was renamed to `hardwareType` from `hwType`.
As title suggested
The text was updated successfully, but these errors were encountered: