Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Rename hwType in EcsOptimizedAmiProps interface to hardwareType #2896

Closed
hencrice opened this issue Jun 17, 2019 · 2 comments · Fixed by #2916 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@hencrice
Copy link
Contributor

As title suggested

@hencrice hencrice added the feature-request A feature should be added or improved. label Jun 17, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 18, 2019

Hi Yenlin, thank you for following the contribution guidelines and creating an issue for your changes!

However, the purpose behind that rule is to justify the changes you are making.
Please add some content here to explain why you think that 'hwType' needs to be renamed!

@NGL321 NGL321 added @aws-cdk/aws-ecs Related to Amazon Elastic Container response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 18, 2019
@NGL321 NGL321 assigned NGL321 and unassigned NGL321 Jun 18, 2019
@hencrice
Copy link
Contributor Author

hencrice commented Jun 18, 2019

Hey Noah,

This suggestion came from an ECS-internal API review. I'm following the guideline here for contribution: https://github.com/awslabs/aws-cdk/blob/master/CONTRIBUTING.md and that was why I created this issue.

rix0rrr pushed a commit that referenced this issue Jun 19, 2019
This change spells out the previously abbreviated `hwType` into `hardwareType` and it closes #2896.

BREAKING CHANGE: 

* **ecs**: the property that specifies the type of EC2 AMI optimized for ECS was renamed to `hardwareType` from `hwType`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment