feat(aws-s3): orphan buckets by default #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the default RemovalPolicy of a Bucket to Orphan. This reduces friction for users with stacks that contain Buckets. In the 99% of cases right now, any activity on a Bucket will cause the stack to fail to delete, and customers are left wondering how to fix this situation (see #1269 for example). It seems better to default to the frictionless case, and have people opt-in to hard deletes if they know for a fact the operation is going to work.
|
I would say it's not a "fix" but rather a "feat" |
eladb
changed the title
eladb
approved these changes
Dec 5, 2018
RomainMuller
approved these changes
Dec 6, 2018
eladb
pushed a commit
that referenced
this pull request
Dec 13, 2018
Since s3 buckets now have DeletionPolicy of "Retain" by default, the init template's expectation file must be updated. Related #1273
eladb
pushed a commit
that referenced
this pull request
Dec 13, 2018
Since s3 buckets now have DeletionPolicy of "Retain" by default, the init template's expectation file must be updated. Related #1273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default RemovalPolicy of a Bucket to Orphan.
This reduces friction for users with stacks that contain Buckets. In the
99% of cases right now, any activity on a Bucket will cause the stack to
fail to delete, and customers are left wondering how to fix this
situation (see #1269 for example).
It seems better to default to the frictionless case, and have people
opt-in to hard deletes if they know for a fact the operation is going to
work.
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
tests
manually executed (paste output to the PR description)
(currently maintained in a private repo).
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.