Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-s3): orphan buckets by default #1273

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Commits on Dec 3, 2018

  1. fix(aws-s3): orphan buckets by default

    Switch the default RemovalPolicy of a Bucket to Orphan.
    
    This reduces friction for users with stacks that contain Buckets. In the
    99% of cases right now, any activity on a Bucket will cause the stack to
    fail to delete, and customers are left wondering how to fix this
    situation (see #1269 for example).
    
    It seems better to default to the frictionless case, and have people
    opt-in to hard deletes if they know for a fact the operation is going to
    work.
    rix0rrr committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    d725ac6 View commit details
    Browse the repository at this point in the history
  2. Fix tests

    rix0rrr committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    8449771 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Configuration menu
    Copy the full SHA
    4214442 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0e58ff View commit details
    Browse the repository at this point in the history