fix handling of description in partitions file #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Nov 17, 2022
SergeyRyabinin
approved these changes
Nov 17, 2022
waahm7
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Partitions file recently introduced a new description field to the region. This breaks partition parsing, since current logic only supports region fields that override the existing default values, but not add to them.
Fixed region fields to have additive behavior. Also filtering out description field from parsing for endpoints, since it has no use in endpoints rule engine, but results in a lot of additional copies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.