Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full object checksum callback #473

Merged
merged 78 commits into from
Dec 10, 2024
Merged

Add full object checksum callback #473

merged 78 commits into from
Dec 10, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Dec 10, 2024 •
edited
Loading

Issue #, if available:

  • Add support for providing full object checksum after streaming the data via a callback
  • previously reviewed in the private repo here

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

TingDaoK added 30 commits June 21, 2024 14:29
@TingDaoK
rewrite some checksum related code
8045073
@TingDaoK
it's just getting worse
51185c6
@TingDaoK
format
6231c60
@TingDaoK
check for error
aca9b76
@TingDaoK
add a log
ce75d8c
@TingDaoK
Merge branch 'checksum-callback' of github.com:awslabs/aws-c-s3 into …
7311370 
…checksum-callback
@TingDaoK
pointer to pointer..
b18dc5e
@TingDaoK
use one function instead of two
ccb46ee
@TingDaoK
Merge branch 'main' into checksum-callback
6698fc9
@TingDaoK
Add crc64
bb3c9b4
@TingDaoK
add support for header checksum
f5362e5
@TingDaoK
add test instead of modify the old one
9b84eb6
@TingDaoK
Add crc64
2247165
@TingDaoK
Merge branch 'crc64' of github.com:awslabs/aws-c-s3-staging into crc64
ec0979f
@TingDaoK
support the full object checksum from header
41df82f
@TingDaoK
With test
09a9aca
@TingDaoK
we need type for both create and complete
425d190
@TingDaoK
CI stuff
58082bc
@TingDaoK
manually cherry pick :)
5318f1f
@TingDaoK
use east-2 bucket as the motorcate only availble from east-2
40512ab
@TingDaoK
the new header was added
f9a1f41
@TingDaoK
fix test and disable the sse-c test, which I believe it's an s3 bug
24ccf1d
@TingDaoK
fine windows.
5ca2e91
@TingDaoK
get CI
740eb8e
@TingDaoK
add support for header checksum
51ef605
@TingDaoK
add test instead of modify the old one
7a87f03
@TingDaoK
Add crc64
1eed0f6
@TingDaoK
add crc64
62fee3e
@TingDaoK
permission
15e8354
@TingDaoK
Merge branch 'latest-CI' into crc64
7771f8b
TingDaoK and others added 24 commits October 28, 2024 09:53
@TingDaoK @graebm
Apply suggestions from code review
529e02d 
Co-authored-by: Michael Graeb <graebm@amazon.com>
@TingDaoK
Merge branch 'crc64' into support-full-object-checksum
5d51e34
@TingDaoK
fix the assert
c5a109c
@TingDaoK
fix assert
2468855
@TingDaoK
merge fix
90166d5
@TingDaoK
Merge branch 'crc64' into support-full-object-checksum
343835d
@TingDaoK
address comments
7792547
@TingDaoK
Merge branch 'support-full-object-checksum' into checksum-callback
106464c
@TingDaoK
adapt change
1264ba2
@TingDaoK
add more documentations
26749ce
@TingDaoK
trivial formatting
63db63d
@TingDaoK
add the same warning
2af2697
@TingDaoK
bring back the sse-c test
e79d201
@TingDaoK
revert the temp change
3ab370a
@TingDaoK
Merge branch 'main' into support-full-object-checksum
b1b1fc1
@TingDaoK
revert ci change
4df9989
@TingDaoK
Merge branch 'support-full-object-checksum' into checksum-callback
623e204
@TingDaoK
address comments
1330da1
@TingDaoK
make sure callbacks will not overlap
de0f416
@TingDaoK
handles it differently
24f0bb0
@TingDaoK
raise an error in case of both header and callback are set
7e0c652
@TingDaoK @graebm
Apply suggestions from code review
ea58704 
Co-authored-by: Michael Graeb <graebm@amazon.com>
@TingDaoK
Merge branch 'checksum-callback' of github.com:awslabs/aws-c-s3 into …
1df7388 
…checksum-callback
@TingDaoK
Merge branch 'main' into checksum-callback
7d22a49
@TingDaoK TingDaoK changed the title Checksum callback Add full object checksum callback Dec 10, 2024
@TingDaoK TingDaoK marked this pull request as ready for review December 10, 2024 22:39
@TingDaoK TingDaoK enabled auto-merge (squash) December 10, 2024 22:51
@TingDaoK TingDaoK merged commit 1e8a980 into main Dec 10, 2024
34 checks passed
@TingDaoK TingDaoK deleted the checksum-callback branch December 10, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graebm graebm graebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @graebm