Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta request]: assign shutdown_callback inside critical region #470

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[meta request]: assign shutdown_callback inside critical region #470

merged 2 commits into from
Dec 3, 2024

Conversation

grrtrr
Copy link
Contributor

@grrtrr grrtrr commented Dec 2, 2024

The shutdown_callback was assigned outside of the critical region, resulting in a race condition.

Move the assignment inside the critical region, right to the end (to ensure that the callback is NULL on error).

Resolves #469.

waahm7
waahm7 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the PR. LGTM!

@waahm7 waahm7 enabled auto-merge (squash) December 3, 2024 20:41
@waahm7 waahm7 merged commit 9c1bd19 into awslabs:main Dec 3, 2024
34 checks passed
@grrtrr
Copy link
Contributor Author

grrtrr commented Dec 3, 2024

@waahm7 - than you for the quick response.

@grrtrr grrtrr deleted the issue_469 branch December 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waahm7 waahm7 waahm7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in setting the shutdown_callback
2 participants
@grrtrr @waahm7