-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make options more const #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd advise checking this branch from aws-crt-cpp, and making sure it all works nicely, before merging
crt cpp actually does not wrap s3 now. i checked cpp sdk and its fine with it. i will check other bindinds |
Issue #, if available:
Description of changes:
make everything passed in by pointer in options const as we always copy the underlying data.
everything that is ref counted is kept as is, since refcounted functions dont play with const ptrs nicely
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.