Endpoint lifetime fix #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for providing a fix. We will look at this at a later stage, need to do some testing. |
graebm
reviewed
Sep 2, 2022
Comment on lines
+725
to
+730
| struct aws_task *async_release_task = aws_mem_calloc(client->allocator, 1, sizeof(struct aws_task)); | ||
| aws_task_init(async_release_task, s_endpoint_release_task, endpoint, "se_endpoint_refcount_task"); | ||
|
|
||
| endpoint->async_release.client = client; | ||
| endpoint->async_release.task = async_release_task; | ||
| endpoint->async_release.task_scheduled = false; |
There was a problem hiding this comment.
trivial: should this endpoint initialization code go in in s3_endpoint.c instead of s3_client.c?
| struct aws_s3_client *client; | ||
| /* If set, the release of endpoint will be scheduled to run within the task to prevent the data race with client | ||
| */ | ||
| struct aws_task *task; |
There was a problem hiding this comment.
why create a new task just for this? why not re-use the client's existing process_work_task?
we could keep an aws_array_list of struct aws_s3_endpoint* to be released
Comment on lines
+589
to
+593
| size_t current_ref = aws_atomic_load_int(&endpoint->ref_count.ref_count); | ||
| num_released = endpoint->async_release.num_released; | ||
| endpoint->async_release.num_released = 0; | ||
| AWS_ASSERT(num_released <= current_ref); | ||
| if (num_released == current_ref) { |
There was a problem hiding this comment.
count might have changed from another thread
| /* The last refcount to release */ | ||
| if (aws_atomic_load_int(&endpoint->ref_count.ref_count) == 1) { | ||
| aws_hash_table_remove(&client->synced_data.endpoints, endpoint->host_name, NULL, NULL); | ||
| if (endpoint->async_release.task) { |
There was a problem hiding this comment.
not a fan of endpoint having 2 "modes", where 1 mode is never used
just needless complexity
|
I took another swing at fixing this over in a new PR: #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.