Multiple Bucket Support #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More WIP changes
justinboswell
approved these changes
Jun 23, 2021
| /* Connection manager shared by all VIP connections. */ | ||
| struct aws_http_connection_manager *http_connection_manager; | ||
| /* Callback for when the reference count of this endpoint hits zero. */ | ||
| aws_s3_endpoint_ref_zero_fn *ref_count_zero_callback; |
There was a problem hiding this comment.
just call this a destructor, I know it's nomenclature that aws_refcount uses, but this is weird to read
|
|
||
| void (*schedule_process_work_synced)(struct aws_s3_client *client); | ||
|
|
||
| void (*process_work)(struct aws_s3_client *client); | ||
|
|
||
| void ( | ||
| *setup_vip_connection_retry_token)(struct aws_s3_client *client, struct aws_s3_vip_connection *vip_connection); | ||
| bool (*endpoint_ref_count_zero)(struct aws_s3_endpoint *endpoint); |
source/s3_endpoint.c
Outdated
| static const uint16_t s_http_port = 80; | ||
| static const uint16_t s_https_port = 443; | ||
|
|
||
| static size_t s_dns_host_address_ttl_seconds = 5 * 60; |
There was a problem hiding this comment.
This should be on the options struct, and default values like this should be centralized (so that when we hook all of this up to ENV vars and config APIs it's easy to find)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.