Secure tunnel v3 #84
Merged
Secure tunnel v3 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Back compat for V3 with V1 and V2 and tests --------- Co-authored-by: Michael Graeb <graebm@amazon.com>
bretambrose
reviewed
Apr 5, 2023
TwistedTwigleg
approved these changes
Apr 7, 2023
| @@ -67,7 +67,7 @@ enum aws_secure_tunnel_message_type { | |||
|
|
|||
| /** | |||
| * ConnectionReset messages convey that the connection has ended, either in error, or closed intentionally for the | |||
| * tunnel peer. | |||
| * tunnel peer. These should not be manually sent from either Destination or Source clients. | |||
There was a problem hiding this comment.
Nitpick: If this is for testing only, which I think was mentioned in the struct/enum for reset, I'd add a note about it here too. Something like "This is only used for testing internally" or something, so the customer knows that they should never expect to see this in a real world application.
* added jitter for reconnecting * remove some logging from websocket request headers
* added ability to pass in tls options * dns ping reduction * builder v0.9.38
* added ability to pass in tls options * dns ping reduction * builder v0.9.38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Connection IDs to Secure Tunnel
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.