Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of places we forget to aws_raise_error() #105

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix a bunch of places we forget to aws_raise_error() #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf206a
Fix a bunch of places we forget to aws_raise_error()
graebm Feb 9, 2024
db6453c
BUILDER_VERSION: v0.9.55
graebm Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- 'main'

env:
BUILDER_VERSION: v0.9.43
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-iot
Expand Down
4 changes: 2 additions & 2 deletions source/secure_tunneling.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ static int s_aws_secure_tunnel_set_stream(
"id=%p: Incomming stream set request for unsupported service_id: " PRInSTR,
(void *)secure_tunnel,
AWS_BYTE_CURSOR_PRI(*service_id));
return AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_BAD_SERVICE_ID;
return aws_raise_error(AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_BAD_SERVICE_ID);
}

struct aws_service_id_element *replacement_elem =
Expand Down Expand Up @@ -2674,7 +2674,7 @@ int aws_secure_tunnel_stream_start(

if (secure_tunnel->config->local_proxy_mode == AWS_SECURE_TUNNELING_DESTINATION_MODE) {
AWS_LOGF_ERROR(AWS_LS_IOTDEVICE_SECURE_TUNNELING, "Stream Start can only be sent from Source Mode");
return AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_INCORRECT_MODE;
return aws_raise_error(AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_INCORRECT_MODE);
}

struct aws_secure_tunnel_operation_message *message_op = aws_secure_tunnel_operation_message_new(
Expand Down
2 changes: 1 addition & 1 deletion source/serializer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,5 +488,5 @@ int aws_secure_tunnel_deserialize_message_from_cursor(
return AWS_OP_SUCCESS;

error:
return AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_DECODE_FAILURE;
return aws_raise_error(AWS_ERROR_IOTDEVICE_SECURE_TUNNELING_DECODE_FAILURE);
}
4 changes: 2 additions & 2 deletions tests/secure_tunnel_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ int secure_tunneling_access_token_check(const struct aws_http_headers *request_h
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}
ASSERT_CURSOR_VALUE_STRING_EQUALS(access_token_cur, s_access_token);
return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

static int s_secure_tunneling_functionality_connect_test_fn(struct aws_allocator *allocator, void *ctx) {
Expand Down Expand Up @@ -952,7 +952,7 @@ int secure_tunneling_client_token_check(const struct aws_http_headers *request_h
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}
ASSERT_CURSOR_VALUE_STRING_EQUALS(client_token_cur, s_client_token);
return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

static int s_secure_tunneling_functionality_client_token_test_fn(struct aws_allocator *allocator, void *ctx) {
Expand Down