Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const pointers in secure_channel_tls_handler.c. #664

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR uses PCCERT_*** types in two cases, which are aliases for const pointers.

Fixes build failures on MinGW.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7
Copy link
Contributor

waahm7 commented Jul 31, 2024

Unfortunately, at the moment we don't support MinGW. What is your use-case? Is this the only problem you are facing with MinGW, or is this just the first of N problems?

@teo-tsirpanis
Copy link
Contributor Author

I discovered this while working updating dependencies (TileDB-Inc/TileDB#5010), and after applying this patch aws-c-io builds in MinGW1. Before making the patch, I tried to build without this warning and without any warnings, but for some reason this warning could not be suppressed and always escalated to an error.

I think this change is good regardless of the MinGW situation, because it matches the constness of the pointers with the API signatures (example 1, example 2).

Footnotes

  1. There was another error in aws-sdk-cpp which needs more thought on if and how to fix upstream.

@waahm7
Copy link
Contributor

waahm7 commented Jul 31, 2024

Thanks, LGTM!

@waahm7 waahm7 enabled auto-merge (squash) July 31, 2024 21:10
@waahm7 waahm7 merged commit e5fe40e into awslabs:main Jul 31, 2024
39 checks passed
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch July 31, 2024 21:16
@waahm7
Copy link
Contributor

waahm7 commented Jul 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants