Fix dev mode login/logout redirect #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
requested review from
bejos-zz,
etsung-aws,
MynockSpit,
nitishdayal and
echo-bravo-yahoo
as code owners
echo-bravo-yahoo
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR is a more complete fix for issue #254, ensuring that Cognito login/logout redirects worked properly in development mode — both locally (with
npm run start), and using the CFN stack output (the S3 bucket containing static built assets). The previous attempted fix only handled the local case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.