Adding sample checks & DTS generation for multistream sample #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirknightj
force-pushed
the
sample-checks
branch
30 times, most recently
from
d87aa3a to
368b67a
Compare
sirknightj
force-pushed
the
sample-checks
branch
from
368b67a to
b885357
Compare
sirknightj
force-pushed
the
sample-checks
branch
from
b885357 to
a07b13f
Compare
sirknightj
added
3.4.3
bug
CI
gstreamer
sirknightj
changed the title
unicornss
reviewed
Feb 7, 2025
| @@ -0,0 +1,290 @@ | |||
| name: Producer CPP Sample Checks | |||
There was a problem hiding this comment.
producer cpp sample checks- build/run for mac/ubuntu 2 versions /windows
unicornss
reviewed
Feb 7, 2025
| while ! /Applications/Docker.app/Contents/Resources/bin/docker info &>/dev/null; do sleep 1; done | ||
|
|
||
| sudo ln -s ~/.docker/run/docker.sock /var/run/docker.sock | ||
|
|
There was a problem hiding this comment.
Can we use gst-rtsp-server?
unicornss
reviewed
Feb 7, 2025
| @@ -259,6 +261,12 @@ static GstFlowReturn on_new_sample(GstElement *sink, CustomData *data) { | |||
|
|
|||
| buffer->pts += data->producer_start_time_map[stream_handle_key] - data->first_pts_map[stream_handle_key]; | |||
|
|
|||
| if (!GST_BUFFER_DTS_IS_VALID(buffer)) { | |||
| buffer->dts = data->last_dts_map[stream_handle_key] + DEFAULT_FRAME_DURATION_MS * HUNDREDS_OF_NANOS_IN_A_MILLISECOND * DEFAULT_TIME_UNIT_IN_NANOS; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR introduces the following improvements and fixes:
CI Enhancements
Bug Fixes
kvssink, so I just ported those changes over to this sample. Verified locally and through the CI that the media can now be uploaded, and checked playback from the AWS console.Resolved minor inconsistencies in CI scripts (e.g., unnecessary trailing spaces, formatting issues).
Implementation notes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.