Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simpler kvssink sample #1121

Closed
wants to merge 9 commits into from
Closed

Conversation

stefankiesz
Copy link
Contributor

Adds a new kvsink sample that allows for simple configuration with command line arguments and defaults to video-only, videotestsrc stream.

Minor fixes in existing kvssink sample.



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Attention: 278 lines in your changes are missing coverage. Please review.

Comparison is base (6af9a7a) 16.38% compared to head (4b5870b) 15.74%.
Report is 1 commits behind head on develop.

❗ Current head 4b5870b differs from pull request most recent head d20a69d. Consider uploading reports for the commit d20a69d to get more accurate results

Files Patch % Lines
samples/kvssink_simple_sample.cpp 0.00% 272 Missing ⚠️
src/gstreamer/gstkvssink.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1121      +/-   ##
===========================================
- Coverage    16.38%   15.74%   -0.64%     
===========================================
  Files           51       52       +1     
  Lines         6849     7126     +277     
===========================================
  Hits          1122     1122              
- Misses        5727     6004     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sirknightj sirknightj added gstreamer Changes to kvssink or the kvssink samples Samples Related to the sample applications labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gstreamer Changes to kvssink or the kvssink samples Samples Related to the sample applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants