Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotaws PR #720 #1117

Closed
wants to merge 4 commits into from
Closed

spotaws PR #720 #1117

wants to merge 4 commits into from

Conversation

stefankiesz
Copy link
Contributor

Running CI tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f365e) 16.34% compared to head (f36ca58) 16.39%.

❗ Current head f36ca58 differs from pull request most recent head abd19dd. Consider uploading reports for the commit abd19dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1117      +/-   ##
===========================================
+ Coverage    16.34%   16.39%   +0.05%     
===========================================
  Files           51       51              
  Lines         6846     6849       +3     
===========================================
+ Hits          1119     1123       +4     
+ Misses        5727     5726       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefankiesz
Copy link
Contributor Author

Closing due to failed address-sanitizer check. Please reopen if the changes in this PR are still a relevant fix for any issues.

@stefankiesz stefankiesz closed this Dec 6, 2023
@niyatim23
Copy link
Contributor

Closing due to failed address-sanitizer check. Please reopen if the changes in this PR are still a relevant fix for any issues.

Here's more on that failure

@stefankiesz stefankiesz reopened this Dec 6, 2023
@stefankiesz stefankiesz closed this Dec 6, 2023
@stefankiesz
Copy link
Contributor Author

It seems PIC related libraries should not be linked with the tests as they are included when linking Producer C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants