Fix GCC and Windows CI Tests #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1105 +/- ##
========================================
Coverage 16.34% 16.34%
========================================
Files 51 51
Lines 6846 6846
========================================
Hits 1119 1119
Misses 5727 5727 ☔ View full report in Codecov by Sentry. |
niyatim23
reviewed
Nov 28, 2023
niyatim23
approved these changes
Nov 29, 2023
stefankiesz
added a commit
that referenced
this pull request
Nov 29, 2023
* Update ci.yml compiler env var * Add refreshenv to windows build * Add import module for refreshenv call * Testing * Revert windows CI changes * Update ci.yml * Trying different PKG_CONFIG_EXECUTABLE path * Add msvc_ to path * More build testing * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * works, testing which line(s) is needed * more * more * Cleanup ci * cleanup cmake * Update README.md * Add check for C vs D drive * Revert ReadMe changes
stefankiesz
added a commit
that referenced
this pull request
Nov 29, 2023
* Update ci.yml compiler env var * Add refreshenv to windows build * Add import module for refreshenv call * Testing * Revert windows CI changes * Update ci.yml * Trying different PKG_CONFIG_EXECUTABLE path * Add msvc_ to path * More build testing * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * works, testing which line(s) is needed * more * more * Cleanup ci * cleanup cmake * Update README.md * Add check for C vs D drive * Revert ReadMe changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac GCC CI Test
Changed to using a direct and versioned compiler path - just pointing to "gcc" and "g++" will map to CLANG compiler on Mac.
Windows MSVC CI Test
Updated PKG_CONFIG_EXECUTABLE to reflect current Chocolatey GSTreamer install path - it is in D: drive now, not C: drive.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.