Experimental support for sequence number validation in the publisher #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the sequence number validation to become an experimental feature that can be removed in the future. Added an annotation for experimental features.
Added a reason value to the annotation, and updated two of the unusual places.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Oct 2, 2018
Reverted 3 commits: Revert "Change version number to 2.0.3-experimental" Revert: 54c171d. Revert "Experimental support for sequence number validation in the publisher (awslabs#401)" Revert: 592499f. Revert "Support Validating Records are From to the Expected Shard (awslabs#400)" Revert: 01f5db8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #391
Moves the sequence number validation to experimental classes. The sequence number validation in the publisher is a temporary measure to determine the cause of misdelivered records.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.