Skip to content

Commit

Permalink
Fix some of the warnings emitted by maven during build (#1363)
Browse files Browse the repository at this point in the history
* Set the source encoding in the pom.

This stops the following warning from being emitted in our logs:

```
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
```

* Replace deprecated systemProperties.

The recommended replacement is systemPropertyVariables, documented [here](https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html).
  • Loading branch information
nakulj authored Jul 8, 2024
1 parent f507066 commit 57dcddf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
14 changes: 4 additions & 10 deletions amazon-kinesis-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -228,16 +228,10 @@
<excludes>
<exclude>**/*IntegrationTest.java</exclude>
</excludes>
<systemProperties>
<property>
<name>sqlite4java.library.path</name>
<value>${sqlite4java.libpath}</value>
</property>
<property>
<name>awsProfile</name>
<value>${awsProfile}</value>
</property>
</systemProperties>
<systemPropertyVariables>
<sqlite4java.library.path>${sqlite4java.libpath}</sqlite4java.library.path>
<awsProfile>${awsProfile}</awsProfile>
</systemPropertyVariables>
</configuration>
</plugin>
<plugin>
Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

<properties>
<awssdk.version>2.25.64</awssdk.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

<licenses>
Expand Down

0 comments on commit 57dcddf

Please sign in to comment.