-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding log-collector-script in EKS AL2 AMI #967
Conversation
"source": "{{template_dir}}/log-collector-script/linux/", | ||
"destination": "/tmp/worker/log-collector-script/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be less confusing to just keep linux
in the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how customers use the existing path. Hence, I didn't update the existing path to ensure its backward compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't /tmp/worker/log-collector-script/
a new path that you're adding, or is it referenced somewhere else?
sudo mkdir -p /etc/eks/log-collector-script/ | ||
sudo cp $TEMPLATE_DIR/log-collector-script/eks-log-collector.sh /etc/eks/log-collector-script/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this and the above needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous step collects files from a different directory. We need this change to copy the log-collector-script from a directory which is in parallel of target path of previous step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The other location is the tmp
directory.
"source": "{{template_dir}}/log-collector-script/linux/", | ||
"destination": "/tmp/worker/log-collector-script/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't /tmp/worker/log-collector-script/
a new path that you're adding, or is it referenced somewhere else?
sudo mkdir -p /etc/eks/log-collector-script/ | ||
sudo cp $TEMPLATE_DIR/log-collector-script/eks-log-collector.sh /etc/eks/log-collector-script/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The other location is the tmp
directory.
Issue #, if available:
Description of changes:
Adding log-collector-script to the AL2 AMI for easier log collection in non-classic partition.
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.