Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new instance types #236

Merged
merged 2 commits into from
May 30, 2019
Merged

Add new instance types #236

merged 2 commits into from
May 30, 2019

Conversation

mogren
Copy link

@mogren mogren commented Mar 29, 2019

Description of changes:

  • Added a1, c5n, m5ad, r5ad

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mogren mogren added the enhancement New feature or request label Mar 29, 2019
@mogren mogren requested review from micahhausler and hmizuma March 29, 2019 18:54
@mogren
Copy link
Author

mogren commented Mar 29, 2019

@voxxit voxxit mentioned this pull request Apr 5, 2019
@JoshuaOnScale
Copy link

CNI 1.3.2 supports c5n. Is there something else blocking this?

* Added a1, c5n, m5ad, r5ad
@mogren
Copy link
Author

mogren commented May 9, 2019

Support added in aws/amazon-vpc-cni-k8s#459

Will be out in v1.5

@mogren
Copy link
Author

mogren commented May 22, 2019

@micahhausler v1.4.1 has all except t3a, v1.5.0 will support all of these types.

@JoshuaOnScale
Copy link

Do the latest published AMIs found here have C5N support? The node yaml still does not contain that type on the list.

Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants