Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #138 correct max-pods for t3/t2.small instances #155

Closed
wants to merge 1 commit into from
Closed

Address issue #138 correct max-pods for t3/t2.small instances #155

wants to merge 1 commit into from

Conversation

andredupreez
Copy link

Issue #138

Updated the t2 and t3.small instances max pods to 11 as per the updated CNI plugin version 1.3.0.
Maximum of 11 pods should be schedulable for the above mentioned instance types.

With the latest CNI version (1.3.0) a maximum of 11 pods should be schedulable for the above mentioned instance types.
@vincentheet
Copy link

vincentheet commented Jan 18, 2019

@micahhausler any chance you can approve and merge this small PR? Currently we have to deploy extra VM's which is not resource efficient.

The change reflects the official documentation https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-eni.html and your VPC CNI plugin correction in PR aws/amazon-vpc-cni-k8s#229

@micahhausler
Copy link
Member

micahhausler commented Jan 18, 2019

We have to hold off on merging this right now, as commented on #116, we have to wait for:

  • Update CNI with new instance type limits - Updated instance types aws/amazon-vpc-cni-k8s#229
  • Release new CNI version with updated instance types - CNI v 1.3.0
  • Set new CNI version as default for new EKS clusters
  • Update max-pods and release new AMI with updated instance types

We're working on making this process better, but for now this is blocked. Once 1.3.0 is released to EKS clusters (in the coming weeks) we'll release a new AMI with this update.

@vincentheet
Copy link

@mogren
Copy link

mogren commented Mar 29, 2019

Fixed in #231

@mogren mogren closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants