Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): Lint - Add eslint-disable to files that haven't been touched since the linter was turned on. #6900

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

cpyle0819
Copy link
Contributor

@cpyle0819 cpyle0819 commented Sep 23, 2024

In addition to disabling the linting, the formatter was also run.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Sep 23, 2024
@cpyle0819 cpyle0819 requested a review from a team September 23, 2024 14:37
@cpyle0819 cpyle0819 self-assigned this Sep 23, 2024
@cpyle0819 cpyle0819 requested review from Laren-AWS and removed request for a team September 23, 2024 14:37
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Sep 23, 2024
@DavidSouther
Copy link
Contributor

IMHO These types of exceptions should be as narrowly tailored as possible (one line, one exception), but this is certainly a start to increase strictness.

@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Sep 26, 2024
@Laren-AWS Laren-AWS added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 26, 2024
@Laren-AWS Laren-AWS merged commit d75cd1e into awsdocs:main Sep 26, 2024
14 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/ignore-lint branch September 30, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants